[Python-il] Code Review: Kakurasu Solver

cool-RR cool-rr at cool-rr.com
Wed Nov 10 00:15:42 IST 2010


On Wed, Nov 10, 2010 at 12:00 AM, Shlomi Fish <shlomif at gmail.com> wrote:

> Hi Ram,
>
> On Tue, Nov 9, 2010 at 12:52 AM, cool-RR <cool-rr at cool-rr.com> wrote:
> > Just one more doc-style comment:
> >
> > def solve(self):
> >         '''
> >         This method attempts to solve the game after self.width ,
> > self.height ,
> >         self.num_known_horiz_constraints ,
> self.num_known_vert_constraints ,
> >         self.horiz_constraints and self.vert_constraints were filled in.
> >
> >         It returns a two-dimensional array containing the rows of the
> > boolean
> >         values with the solution.
> >         '''
> >
> > Here's how this comment should look:
> >
> > def solve(self):
> >         '''
> >
> >         Attempt to solve the game.
> >
> >
> >
> >         This should be called after self.width, self.height,
> >         self.num_known_horiz_constraints,
> self.num_known_vert_constraints,
> >         self.horiz_constraints and self.vert_constraints were filled in.
> >
> >         Returns a two-dimensional array containing the rows of the
> boolean
> >         values with the solution.
> >         '''
> >
> > That's the end of my review-- Since I don't have time to actually
> understand
> > the algorithm.
>
> Thanks! Corrected despite the fact that the plain text version was
> mangled. Did you fail to understand my algorithm despite the fact I
> explained it in a previous message?
>
> Regards,
>
> -- Shlomi Fish
>
>
>
> >
> >
> >
> > Ram,
> >
> > _______________________________________________
> > Python-il mailing list
> > Python-il at hamakor.org.il
> > http://hamakor.org.il/cgi-bin/mailman/listinfo/python-il
> >
> >
>
>
> ------------------------------------------
> Shlomi Fish http://www.shlomifish.org/
>
> Electrical Engineering studies. In the Technion. Been there. Done
> that. Forgot a lot. Remember too much.
>

I didn't even try-- I simply don't have time to go into it.


Ram.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://hamakor.org.il/pipermail/python-il/attachments/20101110/33be1fa7/attachment.htm 


More information about the Python-il mailing list